Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated storybook args #1864

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Fix deprecated storybook args #1864

merged 2 commits into from
Jun 26, 2023

Conversation

TrySound
Copy link
Member

These stories break on upgrade.

See

Code Review

  • hi @kof, I need you to do
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@TrySound TrySound requested a review from kof June 26, 2023 17:06
@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 26, 2023 5:23pm

@TrySound TrySound merged commit 6deecd7 into main Jun 26, 2023
@TrySound TrySound deleted the depreated-args branch June 26, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants