Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrub lost unit on negative values #1853

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Fix scrub lost unit on negative values #1853

merged 3 commits into from
Jun 26, 2023

Conversation

istarkov
Copy link
Member

Description

closes #1846

Steps for reproduction

Drag value scrub to make it eq to 0.
Stop drag.
See unit preserved

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Jun 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 25, 2023 6:50am

@istarkov istarkov changed the title Drop unused radix modules (#1851) Fix scrub lost unit on negative values Jun 25, 2023
@istarkov istarkov requested a review from kof June 25, 2023 06:39
@istarkov istarkov merged commit aec1ca7 into main Jun 26, 2023
@istarkov istarkov deleted the fix-css-value branch June 26, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Unit changes to unitless when scrubbing below 0
2 participants