Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flex-child ordering #1836

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Fix flex-child ordering #1836

merged 2 commits into from
Jun 23, 2023

Conversation

istarkov
Copy link
Member

Description

closes #1833

Steps for reproduction

Create Flex box, add 2 boxes
Change order on any box

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Jun 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 23, 2023 6:48am

@istarkov istarkov requested a review from kof June 23, 2023 06:44
@istarkov istarkov merged commit c59e657 into main Jun 23, 2023
@istarkov istarkov deleted the fix-ordering branch June 23, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ordering of the "order" style property is backwards
2 participants