Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text-align control default value #1822

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Fix text-align control default value #1822

merged 2 commits into from
Jun 19, 2023

Conversation

TrySound
Copy link
Member

Ref #1794

Here fixed initial value in css data. Mdn provides unclear value because of legacy browsers. Here we need to override it with actual "start".

Code Review

  • hi @istarkov, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

Ref #1794

Here fixed initial value in css data. Mdn provides unclear value because
of legacy browsers. Here we need to override it with actual "start".
@TrySound TrySound requested a review from istarkov June 19, 2023 13:33
@vercel
Copy link

vercel bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 19, 2023 2:12pm

@TrySound TrySound merged commit 43868bf into main Jun 19, 2023
@TrySound TrySound deleted the text-align-default branch June 19, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants