Compute currentColor #1815
Merged
Compute currentColor #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref #1536 Here replaced browser getComputedStyle for currentColor with computing from data. `color: inherit` is now considered same as `color: currentColor` and displayed properly in UI. Changed initial value for color from inherit to black (in mdn-data it's canvastext).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
istarkov
reviewed
Jun 19, 2023
apps/builder/app/builder/features/style-panel/shared/style-info.ts
Outdated
Show resolved
Hide resolved
istarkov
reviewed
Jun 19, 2023
apps/builder/app/builder/features/style-panel/shared/style-info.ts
Outdated
Show resolved
Hide resolved
istarkov
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1536
Here replaced browser getComputedStyle for currentColor with computing from data.
color: inheritis now considered same ascolor: currentColorand displayed properly in UI.Changed initial value for color from inherit to black (in mdn-data it's canvastext).
Code Review
Before requesting a review
Before merging
.env.exampleand thebuilder/env-check.jsif mandatory