Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending button #1804

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Add pending button #1804

merged 2 commits into from
Jun 15, 2023

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Jun 15, 2023

Description

Add pending button state
Button size is preserved in case of button is not full-width even in pending state

image

ref #1715

Steps for reproduction

cd packages/design-system
pnpm storybook:run

open

http://localhost:6006/?path=/story/library-button--button

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 15, 2023 8:40pm

@istarkov istarkov requested review from kof and rpominov and removed request for rpominov June 15, 2023 20:36
@istarkov istarkov merged commit 91e0c8f into main Jun 15, 2023
@istarkov istarkov deleted the button-pending branch June 15, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants