Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent selection of pasted data #1782

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Prevent selection of pasted data #1782

merged 2 commits into from
Jun 14, 2023

Conversation

TrySound
Copy link
Member

Ref #34

Looks like selection of pasted data does not work well so here remove it.

Code Review

  • hi @istarkov, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

Ref #34

Looks like selection of pasted data does not work well so here remove it.
@TrySound TrySound requested a review from istarkov June 14, 2023 08:32
@vercel
Copy link

vercel bot commented Jun 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 14, 2023 8:42am

@TrySound TrySound merged commit fa8dc70 into main Jun 14, 2023
@TrySound TrySound deleted the paste-selection branch June 14, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants