Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animated loading icon on publish button #1778

Merged
merged 7 commits into from
Jun 15, 2023
Merged

Add animated loading icon on publish button #1778

merged 7 commits into from
Jun 15, 2023

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Jun 13, 2023

Description

Add animated loading icon on publish button

ref #1715

image

Todo:

Errors are now aligned

image

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 15, 2023 9:24pm

@istarkov istarkov requested review from kof and TrySound and removed request for kof June 13, 2023 13:27
@kof
Copy link
Member

kof commented Jun 14, 2023

@taylornowotny we need to update the design system in figma with having an animated loading svg in the button in the pending state, this is what it looks like right now https://share.descript.com/view/PEa9POv1WUq

I already talked to @markxtang that we need to improve the svg, but that's not the issue here, what we need is a state in figma for the button that is called "pending" and is using the animated svg and works with other states

@istarkov istarkov requested a review from kof June 15, 2023 21:21
@istarkov istarkov merged commit 747facc into main Jun 15, 2023
@istarkov istarkov deleted the publish-animated branch June 15, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants