Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override inherited with html style #1773

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Override inherited with html style #1773

merged 2 commits into from
Jun 13, 2023

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Jun 13, 2023

Html styles override inherited styles. This fixes the issue with link inheriting from body instead of showing predefined in browser style.

image image

Code Review

  • hi @istarkov, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

Html styles override inherited styles. This fixes the issue with link
inheriting from body instead of showing predefined in browser style.
@TrySound TrySound requested a review from istarkov June 13, 2023 06:38
@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 13, 2023 6:53am

@istarkov
Copy link
Member

image

Wrong color for visited shown

@TrySound
Copy link
Member Author

We decided to ignore visited and active because their behavior is hard to reimplement and most likely user won't see it as will redefine stateless link color.

@TrySound TrySound merged commit 08bf34a into main Jun 13, 2023
@TrySound TrySound deleted the html-override-inherited branch June 13, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants