Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link color #1767

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Fix link color #1767

merged 2 commits into from
Jun 12, 2023

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Jun 12, 2023

Description

Now we show in the builder the right color for visited and link itself

image

Tooltip is wrong and not fixed in this PR

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why",
    not "what")

Before merging

  • tested locally and on preview environment (preview dev login:
    5de6)
  • updated test
    cases

    document
  • added tests
  • if any new env variables are added, added them to .env.example
    and the builder/env-check.js if mandatory

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 12, 2023 10:49pm

@istarkov istarkov merged commit 173cc71 into main Jun 12, 2023
@istarkov istarkov deleted the fix-link branch June 12, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants