Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paragraph template wording #1754

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Fix paragraph template wording #1754

merged 2 commits into from
Jun 12, 2023

Conversation

TrySound
Copy link
Member

Ref https://discord.com/channels/955905230107738152/955907841070346300/1114249116566962227

Code Review

  • hi @kof, I need you to do
    • detailed review (read every line)

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@TrySound TrySound requested a review from kof June 12, 2023 12:44
@vercel
Copy link

vercel bot commented Jun 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 12, 2023 1:53pm

@kof kof merged commit e13f3d2 into main Jun 12, 2023
@kof kof deleted the fix-wording branch June 12, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kof kof kof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrySound @kof