Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing text inside button #1739

Merged
merged 3 commits into from
Jun 11, 2023
Merged

Fix editing text inside button #1739

merged 3 commits into from
Jun 11, 2023

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Jun 9, 2023

Ref #1719

Buttons has issue with unavoidable space which prevents entering spaces. Here bind lexical to temporary span inside of button. Now space works fine.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

Ref #1719

Buttons has issue with unavoidable space which prevents entering spaces.
Here bind lexical to temporary span inside of button. Now space works
fine.
@TrySound TrySound requested a review from kof June 9, 2023 22:07
@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 11, 2023 8:46am

Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what should we do about sites already using innerText?

kinda need a migration or keep supporting innerText

@TrySound TrySound merged commit 891a96e into main Jun 11, 2023
@TrySound TrySound deleted the button-children branch June 11, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants