Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store last version in ref #1706

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Store last version in ref #1706

merged 2 commits into from
Jun 2, 2023

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Jun 2, 2023

Ref #1704

Module scope is preserved across projects and does not invalidate last version. Moved to ref to fix.

Code Review

  • hi @istarkov, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

Ref #1704

Module scope is preserved across projects and does not invalidate last
version. Moved to ref to fix.
@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Jun 2, 2023 2:11pm

@TrySound TrySound merged commit 4d34300 into main Jun 2, 2023
@TrySound TrySound deleted the last-version branch June 2, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants