Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip validation #1484

Merged
merged 6 commits into from
Apr 18, 2023
Merged

Skip validation #1484

merged 6 commits into from
Apr 18, 2023

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Apr 18, 2023

Description

On the server for web-studio landing it shows from 230 to 600ms for loading now.
parseBuild time on the server varies from 18ms to 100+ms

locally sometimes I see
image

Steps for reproduction

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Apr 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Apr 18, 2023 4:12pm

@istarkov istarkov marked this pull request as ready for review April 18, 2023 15:58
@istarkov istarkov merged commit c73462e into main Apr 18, 2023
@istarkov istarkov deleted the Skip-parsing branch April 18, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants