Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border radius and other fixes to cascade indicator #1472

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

kof
Copy link
Member

@kof kof commented Apr 16, 2023

Description

Closes #1460

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @istarkov , I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@kof kof linked an issue Apr 16, 2023 that may be closed by this pull request
3 tasks
@vercel
Copy link

vercel bot commented Apr 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Apr 16, 2023 5:00pm

@kof kof changed the title Add border radius to cascade indicator Add border radius and other fixes to cascade indicator Apr 16, 2023
@kof kof requested a review from istarkov April 16, 2023 17:08
@kof kof merged commit dc681c3 into main Apr 16, 2023
@kof kof deleted the 1460-breakpoint-cascade-indicator-line-update branch April 16, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakpoint cascade indicator line update
2 participants