Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tree hover #1429

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Fix tree hover #1429

merged 1 commit into from
Apr 12, 2023

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Apr 12, 2023

There were two problems here. 1 hover out provided item selector which actually made it hovered. And outline was not reset when hover selector is reset.

Code Review

  • hi @istarkov, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

There were two problems here. 1 hover out provided item selector which
actually made it hovered. And outline was not reset when hover selector
is reset.
@TrySound TrySound requested a review from istarkov April 12, 2023 17:07
@vercel
Copy link

vercel bot commented Apr 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview Apr 12, 2023 5:09pm

@TrySound TrySound merged commit 1c0faf7 into main Apr 12, 2023
@TrySound TrySound deleted the fix-tree-hover branch April 12, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants