Breakpoints stage 3 #1413
Merged
Breakpoints stage 3 #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
## Description closes #956 + In case if user not edited the value but immediately clicked to unit select we are trying to convert em px etc values ## Steps for reproduction 1. Edit `width` value, enter 10 go to unit select set `em` - see 10em as final result 2. Click on unit select of the width, change em to px see 10em converted to 140px or like (depends on em size) 3. Enter `Auto` in width, click Enter. Click on UnitSelect select EM, see browser style is used to set em width. 4. Enter Auto in width, switch on Unit select, set px, see browser style is used. 5. See that now unit selector is visible always. With some exclusions like aspectRatio as it has keywords and numeric values. ## Code Review - [x] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio-builder/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env.example` and the `builder/env-check.js` if mandatory
|
Resize feels very chunky especially if any element is selected. We should not recompute styles etc during resize, only on resize end. |
|
Adding breakpoints is confusing and has bug. Bug is that indicator length doesn't change on adding new breakpoint, to reproduce add 1600 breakpoint, then see 768 has no indicator under
The other issue that until done is clicked |
|
Review code contains my commit, better to rebase |
istarkov
reviewed
Apr 11, 2023
istarkov
reviewed
Apr 11, 2023
istarkov
reviewed
Apr 11, 2023
istarkov
reviewed
Apr 11, 2023
istarkov
reviewed
Apr 11, 2023
istarkov
reviewed
Apr 11, 2023
istarkov
reviewed
Apr 11, 2023
istarkov
reviewed
Apr 11, 2023
istarkov
reviewed
Apr 11, 2023
istarkov
approved these changes
Apr 11, 2023
rpominov
approved these changes
Apr 12, 2023
TrySound
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Steps for reproduction
Code Review
hi @TrySound , I need you to do
hi @istarkov , I need you to do
Before requesting a review
Before merging
.env.exampleand thebuilder/env-check.jsif mandatory