Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset returned not existed parameters #1397

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Fix asset returned not existed parameters #1397

merged 1 commit into from
Apr 7, 2023

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Apr 7, 2023

Description

status property returned in asset and killed saas type checks. Again because of spread

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Apr 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2023 1:51pm

@istarkov istarkov merged commit 3cc7289 into main Apr 7, 2023
@istarkov istarkov deleted the fix-asset branch April 7, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants