Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup s3 credentials with asset client #1394

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Setup s3 credentials with asset client #1394

merged 1 commit into from
Apr 7, 2023

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Apr 7, 2023

Ref #1179

Moved s3 client initialization to asset client and passed it to upload and delete.

We may also need to find a way to destroy s3 client.

Code Review

  • hi @istarkov, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@TrySound TrySound requested a review from istarkov April 7, 2023 08:34
@vercel
Copy link

vercel bot commented Apr 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2023 2:51pm

Ref #1179

Moved s3 client initialization to asset client and passed it to upload
and delete.

We may also need to find a way to destroy s3 client.
@TrySound TrySound merged commit 6c9df7c into main Apr 7, 2023
@TrySound TrySound deleted the s3-credential branch April 7, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants