Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to remix 1.15 #1373

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Upgrade to remix 1.15 #1373

merged 2 commits into from
Apr 5, 2023

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Apr 5, 2023

Ref https://github.com/remix-run/remix/releases/tag/remix%401.15.0 and https://remix.run/docs/en/1.15.0/pages/v2

  • bumped to remix 1.15
  • switched to v2 meta
  • replaced serverBuildTarget with fields from examples
  • dropped unused remix-utils

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • test it on preview
  • hi @istarkov, I need you to do
    • detailed review (read every line)

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@TrySound TrySound requested review from kof and istarkov April 5, 2023 07:10
@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 0:10am

TrySound added 2 commits April 5, 2023 19:08
Ref https://github.com/remix-run/remix/releases/tag/remix%401.15.0 and https://remix.run/docs/en/1.15.0/pages/v2

- bumped to remix 1.15
- switched to v2 meta
- replaced serverBuildTarget with fields from examples
- dropped unused remix-utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants