Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop radix icons #1350

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Drop radix icons #1350

merged 2 commits into from
Apr 3, 2023

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Apr 2, 2023

We have all icons in figma. Here replaced with alternatives or exported from figma. See diff.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

We have all icons in figma. Here replaced with alternatives or exported
from figma. See diff.
@vercel
Copy link

vercel bot commented Apr 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webstudio-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2023 5:06pm

@TrySound TrySound merged commit c5c90f6 into main Apr 3, 2023
@TrySound TrySound deleted the drop-radix-icons branch April 3, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants