Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize css #1333

Merged
merged 7 commits into from
Mar 31, 2023
Merged

Normalize css #1333

merged 7 commits into from
Mar 31, 2023

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Mar 31, 2023

Description

closes #473

${tag}:where([${componentAttribute}=${component}]) where is used to not increase specificity

  • todo remove from getInheritedInfo, as we don't know ancestor tagName

Steps for reproduction

See box-sizing etc props for newly created items

Code Review

  • hi @kof, I need you to do

    • conceptual review (architecture, feature-correctness)
  • hi @TrySound , I need you to do

    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
webstudio-builder ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 2:25PM (UTC)

@istarkov istarkov requested a review from kof March 31, 2023 12:21
@istarkov istarkov requested a review from TrySound March 31, 2023 12:21
@istarkov istarkov marked this pull request as ready for review March 31, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Normalize for the build
2 participants