Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor selected outline with store #1317

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

TrySound
Copy link
Member

One less pubsub event replaced with store. Now hovered and selected logic is similar.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

One less pubsub event replaced with store. Now hovered and selected
logic is similar.
@TrySound TrySound requested a review from kof March 29, 2023 06:43
@vercel
Copy link

vercel bot commented Mar 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webstudio-builder ✅ Ready (Inspect) Visit Preview Mar 29, 2023 at 6:43AM (UTC)

@TrySound TrySound merged commit 2c7184c into main Mar 30, 2023
@TrySound TrySound deleted the selected-instance-outline-store branch March 30, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants