Skip to content

Commit

Permalink
fix: fix vimeo autoplay (#4664)
Browse files Browse the repository at this point in the history
## Description

Don't set backgrounMode on the video at all, otherwise it will override
the autoplay value

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
  • Loading branch information
kof authored Dec 28, 2024
1 parent 3ea15c5 commit 6b234dc
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions packages/sdk-components-react/src/vimeo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,6 @@ export const Vimeo = forwardRef<Ref, Props>(
loading = "lazy",
autoplay = false,
autopause = true,
backgroundMode = false,
showByline = false,
showControls = true,
doNotTrack = false,
Expand Down Expand Up @@ -381,7 +380,6 @@ export const Vimeo = forwardRef<Ref, Props>(
url,
autoplay,
autopause,
backgroundMode,
showControls,
controlsColor,
doNotTrack,
Expand Down

0 comments on commit 6b234dc

Please sign in to comment.