Invoke the close callback when the close event is emitted #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
commented
Nov 15, 2016
| error = e; | ||
| } | ||
| } | ||
| for (const client of this.clients) client.terminate(); |
There was a problem hiding this comment.
I've removed the try...catch statement because WebSocket.prototype.terminate() does not throw errors.
There was a problem hiding this comment.
But doesn't the underlaying node code could be throwing errors.
lpinca
force-pushed
the
fix/close-callback
branch
from
e033f24
to
084369d
Compare
|
nvm, all those other functions are already wrapping all socket calls in |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the close callback is invoked immediately but it should be called when the HTTP server emits the 'close' event.