Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Sender inheritance from EventEmitter #861

Merged
merged 1 commit into from
Oct 14, 2016
Merged

Remove Sender inheritance from EventEmitter #861

merged 1 commit into from
Oct 14, 2016

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Oct 13, 2016 •
edited
Loading

The only event emitted by Sender is error so I think it makes sense to not make it inherit from EventEmitter and only use an onerror function instead.

This is also consistent with the Receiver class.

@JacksonTian
Copy link
Contributor

LGTM

@lpinca lpinca merged commit 5a0b6f5 into master Oct 14, 2016
@lpinca lpinca deleted the remove/inheritance branch October 14, 2016 05:56
@lpinca lpinca mentioned this pull request Dec 12, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpinca @JacksonTian