Skip to content

add option 'clear' mask #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

add option 'clear' mask #1988

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71e3b21
add option 'clear' mask
e3dio Dec 18, 2021
9a22689
limit target buffer size
e3dio Dec 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/sender.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ class Sender {
* @param {Object} options Options object
* @param {Boolean} [options.fin=false] Specifies whether or not to set the
* FIN bit
* @param {Boolean} [options.mask=false] Specifies whether or not to mask
* `data`
* @param {Boolean|String} [options.mask=false] Specifies whether or not to mask
* `data`. A 'clear' value applies an empty mask to improve performance
* @param {Number} options.opcode The opcode
* @param {Boolean} [options.readOnly=false] Specifies whether `data` can be
* modified
Expand All @@ -53,7 +53,8 @@ class Sender {
* @public
*/
static frame(data, options) {
const merge = options.mask && options.readOnly;
const clear = options.mask == 'clear';
const merge = options.mask && options.readOnly && !clear;
let offset = options.mask ? 6 : 2;
let payloadLength = data.length;

Expand Down Expand Up @@ -81,14 +82,16 @@ class Sender {

if (!options.mask) return [target, data];

randomFillSync(mask, 0, 4);
clear ? mask.fill(0) : randomFillSync(mask, 0, 4);

target[1] |= 0x80;
target[offset - 4] = mask[0];
target[offset - 3] = mask[1];
target[offset - 2] = mask[2];
target[offset - 1] = mask[3];

if (clear) return [target, data];

if (merge) {
applyMask(data, mask, target, offset, data.length);
return [target];
Expand Down