Adds a space after emoji, fixes #43 #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukben
requested changes
Dec 5, 2017
jvorcak
force-pushed
the
fix/space-after-emoji
branch
2 times, most recently
from
e8cfee9 to
383603e
Compare
|
@jukben I've added next |
jukben
force-pushed
the
fix/space-after-emoji
branch
from
383603e to
21db57c
Compare
|
Wonderful contribution! Thanks a lot. I particularly like how you have refactored the E2E test. Good job, indeed. I appreciate your opinion and I will bear it in mind and I will change the default value of this option in favor "next" in the next major release. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.