Skip to content

Detect browser without relying on vendor prefixes #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Detect browser without relying on vendor prefixes #1160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 21 additions & 29 deletions src/js/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,16 +149,11 @@ export function deprecated(oldMethod, newMethod) {
* properties.
*/
export function detectBrowser(window) {
// Returned result object.
const result = {browser: null, version: null};

// Fail early if it's not a browser
if (typeof window === 'undefined' || !window.navigator ||
!window.navigator.userAgent) {
result.browser = 'Not a browser.';
return result;
return {browser: 'Not a browser.', version: null};
}

const {navigator} = window;

// Prefer navigator.userAgentData.
Expand All @@ -171,32 +166,29 @@ export function detectBrowser(window) {
}
}

if (navigator.mozGetUserMedia) { // Firefox.
result.browser = 'firefox';
result.version = extractVersion(navigator.userAgent,
/Firefox\/(\d+)\./, 1);
} else if (navigator.webkitGetUserMedia ||
(window.isSecureContext === false && window.webkitRTCPeerConnection)) {
const ua = navigator.userAgent;
const firefoxVer = extractVersion(ua, /Firefox\/(\d+)\./, 1);
if (firefoxVer) {
return {browser: 'firefox', version: firefoxVer};
}
const chromeVer = extractVersion(ua, /Chrom(e|ium)\/(\d+)\./, 2);
if (chromeVer) {
// Chrome, Chromium, Webview, Opera.
// Version matches Chrome/WebRTC version.
// Chrome 74 removed webkitGetUserMedia on http as well so we need the
// more complicated fallback to webkitRTCPeerConnection.
result.browser = 'chrome';
result.version = extractVersion(navigator.userAgent,
/Chrom(e|ium)\/(\d+)\./, 2);
} else if (window.RTCPeerConnection &&
navigator.userAgent.match(/AppleWebKit\/(\d+)\./)) { // Safari.
result.browser = 'safari';
result.version = extractVersion(navigator.userAgent,
/AppleWebKit\/(\d+)\./, 1);
result.supportsUnifiedPlan = window.RTCRtpTransceiver &&
'currentDirection' in window.RTCRtpTransceiver.prototype;
} else { // Default fallthrough: not supported.
result.browser = 'Not a supported browser.';
return result;
return {browser: 'chrome', version: chromeVer};
}

return result;
const safariVer = extractVersion(ua, /AppleWebKit\/(\d+)\./i, 1);
if (safariVer && /Safari/.test(ua)) {
// Version is the AppleWebKit one for adapter backwards compat
return {
browser: 'safari',
version: safariVer,
supportsUnifiedPlan:
window.RTCRtpTransceiver &&
'currentDirection' in window.RTCRtpTransceiver.prototype
};
}
return {browser: 'Not a supported browser.', version: null};
}

/**
Expand Down
1 change: 0 additions & 1 deletion test/unit/adapterfactory.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ describe('adapter factory', () => {

it('does not throw in Firefox with peerconnection disabled', () => {
window = {navigator: {
mozGetUserMedia: () => {},
mediaDevices: {getUserMedia: () => {}},
userAgent: 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:44.0) ' +
'Gecko/20100101 Firefox/44.0'
Expand Down
18 changes: 3 additions & 15 deletions test/unit/detectBrowser.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,18 @@ describe('detectBrowser', () => {
window = {navigator};
});

it('detects Firefox if navigator.mozGetUserMedia exists', () => {
it('detects Firefox', () => {
navigator.userAgent = 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; ' +
'rv:44.0) Gecko/20100101 Firefox/44.0';
navigator.mozGetUserMedia = function() {};

const browserDetails = detectBrowser(window);
expect(browserDetails.browser).toEqual('firefox');
expect(browserDetails.version).toEqual(44);
});

it('detects Chrome if navigator.webkitGetUserMedia exists', () => {
it('detects Chrome', () => {
navigator.userAgent = 'Mozilla/5.0 (X11; Linux x86_64) ' +
'AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.101 ' +
'Safari/537.36';
navigator.webkitGetUserMedia = function() {};
window.webkitRTCPeerConnection = function() {};

const browserDetails = detectBrowser(window);
expect(browserDetails.browser).toEqual('chrome');
expect(browserDetails.version).toEqual(45);
Expand All @@ -41,9 +36,6 @@ describe('detectBrowser', () => {
navigator.userAgent = 'Mozilla/5.0 (X11; Linux x86_64) ' +
'AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.0.0 ' +
'Safari/537.36';
navigator.webkitGetUserMedia = function() {};
window.webkitRTCPeerConnection = function() {};

const browserDetails = detectBrowser(window);
expect(browserDetails.browser).toEqual('chrome');
expect(browserDetails.version).toEqual(95);
Expand All @@ -54,18 +46,14 @@ describe('detectBrowser', () => {
// Use the wrong UA string for Firefox.
navigator.userAgent = 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; ' +
'rv:44.0) Gecko/20100101 Firefox/44.0';
navigator.mozGetUserMedia = function() {};

const browserDetails = detectBrowser(window);
expect(browserDetails.browser).toEqual('chrome');
expect(browserDetails.version).toEqual(102);
});

it('detects Safari if window.RTCPeerConnection exists', () => {
it('detects Safari', () => {
navigator.userAgent = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) ' +
'AppleWebKit/604.1.6 (KHTML, like Gecko) Version/10.2 Safari/604.1.6';
window.RTCPeerConnection = function() {};

const browserDetails = detectBrowser(window);
expect(browserDetails.browser).toEqual('safari');
expect(browserDetails.version).toEqual(604);
Expand Down