This repository has been archived by the owner on May 13, 2024. It is now read-only.
Peer2peer - Fix setLocalDescription parsing error when forceIsac is used #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaptenJansson
changed the title
|
I know the webcomponents and vulcanize changes in this Pull request are unrelated but they needed updating due to grunt complaining because travis pulls down the latest versions and 0.5.0 of webcomponentsjs were no longer available from NPM it seems and the one it pulled down, 0.6.2 breaks the dependancies due to not matching ^0.5.0. |
| if (color === 'red') { | ||
| throw new Error(message); | ||
| } | ||
| console.log(message); |
There was a problem hiding this comment.
nit: Why have you moved this line down? that way it will not be logged when actually throwing an error.
There was a problem hiding this comment.
I moved it so that it does not print the message twice when errors occur. It will still be printed for non errors (i.e. color !== red)
|
lgtm |
KaptenJansson
added a commit
that referenced
this pull request
May 26, 2015
Peer2peer - Fix setLocalDescription parsing error when forceIsac is used
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #86