Conversation
src/index.html
Outdated
There was a problem hiding this comment.
Use console.error() for errors. Or is that hard since we only catch what's in console.log?
There was a problem hiding this comment.
We werenot using console.error before...lets do that sort of cleanup after.
…lean js a bit more.
|
Did some more testing, the test result prefixes are no longer present (OK, INFO, WARNING, FAILED) |
|
Also filing a bug from the initial fail gum dialog results in a RangeError which prevents the user from entering an issue description. Bug reporting from the title menu works fine.
|
|
Worth noting is that the initial gum dialog is often rendered to the right rather than in the middle, I remember seeing the in the old polymer as well but I believe we did solve it somehow, not sure how though. |
|
Sorry for not looking thoroughly enough initially. |
|
Fixed:
Not fixed:
|
|
LGTM, very nice work! A lot cleaner code! |
Convert testrtc to polymer 1.0
|
Vulcanization is not working properly, noticed this when pushing to https://2-dot-test-rtc.appspot.com/. One thing I did notice is that the strip and inline methods are replace with inlineScripts, inlineCss and stripComments. Changing to those does not solve it though. Will continue to investigate. |

Hi @KaptenJansson, can you have a look on this and see what features I might have broken?
If you think this starts to look almost ready then I will clean the code and make sure the tests.