states: add e2e tests #1546
Merged
states: add e2e tests #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alvestrand @henbos there is an interesting thing about this sample that I only noticed when writing the test: |
|
Yeah I think we should calculate connectionState the same way we calculate iceConnectionState, in blink, so that it matches the JS exposed transport states. But incidentally connectionState still exposes the ”failed” heuristic that was removed from iceConnectionState. My kingdom for an end-of-candidates |
|
ah... turns out there was an extra call adding the 'new' / 'stable' state to the div. Not a spec issue, a sample issue. Updated the sample and the test. |
KaptenJansson
approved these changes
Apr 25, 2022
KaptenJansson
approved these changes
Apr 25, 2022
and fix misc bugs and terminology
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fix misc bugs and terminology