Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow stuns: URIs in the trickle ICE sample #1535

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Allow stuns: URIs in the trickle ICE sample #1535

merged 2 commits into from
Apr 7, 2022

Conversation

rhansen
Copy link
Contributor

@rhansen rhansen commented Apr 5, 2022

The stuns URI scheme is defined in https://www.rfc-editor.org/rfc/rfc7064.html#section-3

alvestrand
alvestrand approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Note that allowing it in the sample is no guarantee of browser support, but being able to enter the URL is required to test that, so it's goodness anyway.

@fippo
Copy link
Collaborator

fippo commented Apr 6, 2022

iirc the reason we do the filtering and alerting manually is that we don't catch failures to construct the peerconnection - chrome throws when it encounters stuns:

@rhansen rhansen force-pushed the trickle-ice-stuns branch 2 times, most recently from 147eb62 to 54abf0e Compare April 6, 2022 08:04
@rhansen
Copy link
Contributor Author

rhansen commented Apr 6, 2022

I pushed a commit to display the Chrome error.

@rhansen rhansen force-pushed the trickle-ice-stuns branch 2 times, most recently from 76d0547 to 2c4bbac Compare April 6, 2022 08:10
@fippo fippo merged commit 69da7b7 into webrtc:gh-pages Apr 7, 2022
@fippo
Copy link
Collaborator

fippo commented Apr 7, 2022

thank you for splitting up the commits nicely too!

@fippo fippo mentioned this pull request Apr 7, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvestrand alvestrand alvestrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhansen @fippo @alvestrand