Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Merge-104] Remove excessive log spam from receiver.getParameters().
It's normal for a receiver to not be configured to receive, such as when currentDirection is not (or not yet) "sendrecv" or "recvonly". getParameters() returning an empty set of encodings is valid and these logs are not very useful. It's also inconsistent that we only log after SLD has happened due to different code paths inside getParameters(), repro: https://jsfiddle.net/henbos/xqksj3wd/. Most notably we're calling getParameters() internally from inside of getStats() which can cause excessive log spam. I prefer that we remove these logs rather than avoid calling getParameters() from inside of getStats() on non-receiving receivers since it's valid to check how many encodings exist on a receiver using getParameters(), and whether or not the SSRC has been signaled could in theory affect the number of encodings even if we do want to receive. Also an app calling getParameters() on an inactive receiver is valid and should not cause logs. (cherry picked from commit 73ee252) No-Try: True Bug: webrtc:14225, chromium:1339762 Change-Id: I4290781d6aed92aa03fe0c662762aa97c99a045c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266960 Commit-Queue: Erik Språng <sprang@webrtc.org> Auto-Submit: Henrik Boström <hbos@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Original-Commit-Position: refs/heads/main@{#37335} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267060 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/branch-heads/5112@{#3} Cr-Branched-From: a976a87-refs/heads/main@{#37168}
- Loading branch information