Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media_engine: Properly return codec when not negotiated #595

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

haaspors
Copy link
Contributor

Also added a test I found in Pion, however not really a test this PR affects.

It should be said that this fix is needed for RtpReceiver to work properly when using ORTC API.

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 61.35%. Comparing base (4bb9614) to head (523803d).

Files Patch % Lines
webrtc/src/api/media_engine/media_engine_test.rs 22.22% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
- Coverage   61.35%   61.35%   -0.01%     
==========================================
  Files         532      532              
  Lines       49715    49720       +5     
  Branches    12601    12619      +18     
==========================================
+ Hits        30504    30506       +2     
+ Misses       9868     9866       -2     
- Partials     9343     9348       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rainliu rainliu merged commit c32345d into webrtc-rs:master Jul 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants