Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send side Simulcast/Track encodings #578

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

haaspors
Copy link
Contributor

Most of this is ported from different patches in pion related to send side simulcast.

First and foremost, a track can now be created with a specific RID, and RtpSender::add_encoding() is used for adding track encodings. Also, MID and RID RTP header extensions are automatically added when sending RTP/Samples on local tracks. All of this would only work if MID and RID header extensions are enabled/registered on media engine.

This change makes it possible to set the RTP stream ID to
allow forwarding and production of simulcast streams.
Introduces add_encoding method in RTP sender to add simulcast encodings.
Ported over from pion
This is a port from a pion test
When MID and RTP stream ID header extension are enabled all RTP packets
get corresponding MID and RID added as extension headers.
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 66.50718% with 140 lines in your changes missing coverage. Please review.

Project coverage is 61.80%. Comparing base (ae93e81) to head (539532b).
Report is 1 commits behind head on master.

Files Patch % Lines
.../src/rtp_transceiver/rtp_sender/rtp_sender_test.rs 69.16% 5 Missing and 65 partials ⚠️
...tc/src/peer_connection/peer_connection_internal.rs 28.81% 36 Missing and 6 partials ⚠️
webrtc/src/peer_connection/peer_connection_test.rs 77.52% 2 Missing and 18 partials ⚠️
...tc/src/track/track_local/track_local_static_rtp.rs 75.00% 2 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   61.57%   61.80%   +0.22%     
==========================================
  Files         532      532              
  Lines       48970    49331     +361     
  Branches    12416    12500      +84     
==========================================
+ Hits        30155    30487     +332     
+ Misses       9582     9507      -75     
- Partials     9233     9337     +104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rainliu rainliu merged commit 89285ce into webrtc-rs:master Jun 20, 2024
5 checks passed
@haaspors haaspors mentioned this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants