Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: typos #490

Merged
merged 4 commits into from
Sep 3, 2023
Merged

fix!: typos #490

merged 4 commits into from
Sep 3, 2023

Conversation

LeoDog896
Copy link
Contributor

@LeoDog896 LeoDog896 commented Sep 2, 2023

uses crate-ci/typos.

in the state that its in now, it breaks 3 enums, demanding a minor release.

@LeoDog896 LeoDog896 changed the title ci: catch typos fix!: typos Sep 2, 2023
Copy link
Member

@rainliu rainliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is quite useful. Thanks for the efforts.

_typos.toml Outdated Show resolved Hide resolved
_typos.toml Outdated Show resolved Hide resolved
causes shadowing, but the shawoing makes perfect sense
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch coverage: 54.28% and project coverage change: -0.25% ⚠️

Comparison is base (b0d5662) 61.78% compared to head (bf2ed0a) 61.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
- Coverage   61.78%   61.54%   -0.25%     
==========================================
  Files         530      530              
  Lines       48860    48863       +3     
  Branches    12332    12349      +17     
==========================================
- Hits        30188    30071     -117     
- Misses       9509     9609     +100     
- Partials     9163     9183      +20     
Files Changed Coverage Δ
...rc/algorithms/fitness_distance/value_constraint.rs 98.07% <ø> (ø)
...orithms/fitness_distance/value_range_constraint.rs 69.64% <ø> (ø)
constraints/src/algorithms/select_settings.rs 58.33% <ø> (ø)
dtls/src/flight/flight4.rs 56.69% <ø> (ø)
dtls/src/fragment_buffer/fragment_buffer_test.rs 77.19% <ø> (-4.95%) ⬇️
.../handshake/handshake_cache/handshake_cache_test.rs 97.11% <ø> (ø)
ice/src/agent/agent_config.rs 85.71% <ø> (ø)
ice/src/agent/agent_test.rs 66.28% <ø> (-0.22%) ⬇️
.../src/external_ip_mapper/external_ip_mapper_test.rs 50.93% <0.00%> (ø)
ice/src/udp_mux/udp_mux_test.rs 62.26% <0.00%> (-1.26%) ⬇️
... and 41 more

... and 82 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rainliu rainliu merged commit 487ea32 into webrtc-rs:master Sep 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants