Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of dtls connection with lite ice role #455

Merged

Conversation

oto313
Copy link

@oto313 oto313 commented Jun 6, 2023

Currently the stack cannot handle ICE-LITE peer and correctly initiate connection. This fix adjusts the correct DTLS role for ICE-LITE peer

Pion commit

@yngrtc yngrtc force-pushed the feature/fix-dtls-connection-with-lite-ice-role branch from 347ab59 to a1c8844 Compare June 12, 2023 04:00
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (7bf1438) 61.52% compared to head (a1c8844) 61.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   61.52%   61.48%   -0.05%     
==========================================
  Files         537      537              
  Lines       49466    49500      +34     
  Branches    12320    12331      +11     
==========================================
+ Hits        30436    30437       +1     
- Misses       9866     9880      +14     
- Partials     9164     9183      +19     

see 46 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yngrtc yngrtc merged commit 8168625 into webrtc-rs:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants