Fix SSE timeout bug #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkieltyka
approved these changes
Sep 30, 2024
VojtechVitek
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
LGTM
Let's look into this syntax proposal too:
webrpc/webrpc#311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the stream gets dropped without being properly closed, the client needs to end the stream. The current implementation errors out with an global error instead of triggering the onError hook.
This is caused by an incorrect throwing of an error inside of a setIntervall (see "the this problem" on MDN)
This resolves the problem, by setting an error flag that triggers the timeout error. Instead of throwing directly from the setIntervall