-
-
Notifications
You must be signed in to change notification settings - Fork 56
feat: Review crawl without analysis run #2719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1e7ad09
to
b9ba80b
Compare
In general, this is looking nice and working well, but I think will require a little more work to make the scenario where users actually do want to run the QA analysis a bit easier/better. Take the scenario of a new user who clicks on the "Add Review" link from the workflow after a crawl completes. Not being already familiar with our QA system, they'd only know that they can add additional information into the Review Dashboard by running analysis if they dig into a tooltip's text. If they do see that text, there's no button in the Review Dashboard to then go ahead and do that, and no easy link to direct them to the page where they'd have to kick that off. They'd only see a "Return to Workflow" link and "Exit Review", which also takes them back to the workflow. And then they'd have to know to navigate to the crawl object's QA tab on their own. it might be that we could address this by adding a button to run Analysis directly in the Review Dashboard? That might require some additional UI changes though, e.g. to see the status of the run. Alternatively, we could provide a link to the crawl detail QA tab so that they can do it there, but making users go out to a different page, hit a button, and then come back also feels a little clunky. In addition, I think we may need to update the docs a bit to reflect the changes made in this PR. |
That seems like a good start! And maybe a link to the crawl's QA pane somewhere? |
8530c68
to
d9e7934
Compare
I feel like "+ Add Review" ends up being a little confusing, I'd expect it to immediately let you add a review/rating, rather than taking you to a separate review page for you to then do the reviewing. Maybe "+ Review Crawl" would make more sense? |
Also I think the note about "comparison view unavailable" is a useful one to leave in maybe? |
Updated! |
"Screenshot, text, and resource quality metrics are only available for analyzed crawls. Run analysis to view and compare all QA metrics.", | ||
)} | ||
> | ||
<div | ||
class="flex items-center gap-1.5 text-xs text-neutral-500" | ||
> | ||
<sl-icon class="text-sm" name="info-circle"></sl-icon> | ||
${msg("Limited view")} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open to suggestions on how to label and word this (cc @DaleLore )

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might include "comparison" in a couple places? i.e.
Screenshot comparison, text comparison, and resource quality metrics are only available for analyzed crawls. Run analysis to view and compare all QA metrics.
Resolves #2718
Changes
Enables manual QA review for successfully finished crawls.
Manual testing
Screenshots
Follow-ups
We should update the user guide and any related resources #2730