Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headful interactive profile creation broken after v1.4.0 update #726

Closed
halvir opened this issue Nov 26, 2024 · 1 comment · Fixed by #727
Closed

Headful interactive profile creation broken after v1.4.0 update #726

halvir opened this issue Nov 26, 2024 · 1 comment · Fixed by #727

Comments

@halvir
Copy link

halvir commented Nov 26, 2024

The headful interactive profile creation is not functional after updating Browsertrix-Crawler to version 1.4.0 release.
Error displayed on command line is following:

node:fs:448
    return binding.readFileUtf8(path, stringToFlags(options.flag));
                   ^

Error: ENOENT: no such file or directory, open '/app/node_modules/@novnc/novnc/core/rfb.js'
    at Object.readFileSync (node:fs:448:20)
    at InteractiveBrowser.handleRequest (file:///app/dist/create-login-profile.js:499:29)
    at Server.<anonymous> (file:///app/dist/create-login-profile.js:329:65)
    at Server.emit (node:events:518:28)
    at parserOnIncoming (node:_http_server:1141:12)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:118:17) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/app/node_modules/@novnc/novnc/core/rfb.js'
}

Node.js v20.18.1

Headless interactive profile creation seems to be working as intended.

@ikreymer
Copy link
Member

Thanks for the report, novnc should not have been updated, will add a fix to pin it to 1.4.0 shortly.

ikreymer added a commit that referenced this issue Nov 26, 2024
…5.0 not compatible with current configuration)

fixes #726
bump to 1.4.1
ikreymer added a commit that referenced this issue Nov 26, 2024
- novnc 1.5.0 not compatible with current configuration)
- fixes #726
- bump to 1.4.1
@github-project-automation github-project-automation bot moved this from Triage to Done! in Webrecorder Projects Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done!
Development

Successfully merging a pull request may close this issue.

2 participants