Skip to content

Conversation

@tomvdv
Copy link

@tomvdv tomvdv commented Feb 11, 2014

When using MySQL 5.6+, a warning is displayed when setting the password on the command line using the -p option:
Warning: Using a password on the command line interface can be insecure.

The warning is prepended to db_backup.sql, which causes the subsequent import to fail.

@timnovinger
Copy link

I'm also having this issue. It would be great to see a solution pulled into master.

@darioghilardi
Copy link
Member

Hello,
thanks for the pull request, I am going to take a look as soon as possibile to fix the problem in a clean way.
Thank you again.

@hallodom
Copy link

Sorry think I just duplicated this issue! Would be great to have a clean solution :) thanks.

@wesbos
Copy link

wesbos commented Apr 29, 2014

I'm also having this issue and it's stopping the plugin from working - a fix or at least this merged into master would be great

@mtv
Copy link

mtv commented May 27, 2014

Hello,
and thank you for a usefull grunt module.

I have found the reason for why the "Warning:..." line is included in the dump file.

You can see the why here: https://github.com/arturadib/shelljs#execcommand--options--callback When executing mysqldump synchronously both stderr and stdout is piped into the output. Here is the code running shelljs: https://github.com/webrain/grunt-wordpress-deploy/blob/master/tasks/lib/util.js#L14

I see 2 possible solutions here:

  1. Remove all lines preceding the first comment line
  2. Rewrite the use of shelljs to be async. Requires a bigger rewrite of code, but will give a better solution to the problem.

Regards.

@goellner
Copy link

+1

The only thing preventing me from using this plugin is the warning message in the mysql dump. Is it possible to merge tomvdv's pull request, so it is usable in the meantime?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants