Skip to content

docs(configuration): document webpackIgnore for commonjs #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chenxsan
Copy link
Member

closes #4470

@vercel
Copy link

vercel bot commented Jan 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/q6jes7ii2
✅ Preview: https://webpack-js-org-git-fork-chenxsan-feature-document-common-c1c06e.webpack-docs.vercel.app


Enable [magic comments](/api/module-methods/#magic-comments) support for CommonJS.

- Type: `boolean`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually put the types below the title, Why this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's explicit, and I believe it's much readable. Moreover, with explicit format we could possibly customize those complex types with <details> element in the future.

@chenxsan chenxsan closed this Feb 2, 2021
@chenxsan chenxsan reopened this Feb 2, 2021
@chenxsan chenxsan merged commit cc52033 into webpack:master Feb 2, 2021
@chenxsan chenxsan deleted the feature/document-commonjs-webpackIgnore branch February 2, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document webpack change: feat(CommonJsPlugin): magic comment to ignore require calls
2 participants