Skip to content

Docs(api): add asset info for sourceFilename and javascriptModule#4116

Merged
chenxsan merged 2 commits intowebpack:masterfrom
jeffin143:fix-4089
Nov 13, 2020
Merged

Docs(api): add asset info for sourceFilename and javascriptModule#4116
chenxsan merged 2 commits intowebpack:masterfrom
jeffin143:fix-4089

Conversation

@jeffin143
Copy link
Contributor

@jeffin143 jeffin143 commented Nov 1, 2020

fix #4089

  • Read and sign the [CLA][1]. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the [writer's guide][2].
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: [Stale Pull Requests][3].

@vercel
Copy link

vercel bot commented Nov 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/iecgwbhkh
✅ Preview: https://webpack-js-org-git-fix-4089.webpack-docs.vercel.app

Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like commas are missing.

@montogeek montogeek added the API label Nov 4, 2020
@chenxsan chenxsan merged commit 1b13f7f into webpack:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document webpack change: add asset info for sourceFilename and javascriptModule

4 participants