Skip to content

fix(dev-server): remove hotOnly #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

fix(dev-server): remove hotOnly #3727

wants to merge 6 commits into from

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented May 3, 2020

DON'T MERGE

Remove hotONly, see webpack/webpack-dev-server#2546

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.

@vercel
Copy link

vercel bot commented May 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/h7iql6jvm
✅ Preview: https://webpack-js-org-git-feature-modify-hot.webpack-docs.vercel.app

@jeffin143
Copy link
Contributor

I guess we should remove DON'T MERGE since the pr is merged

@montogeek
Copy link
Member

montogeek commented May 13, 2020

It could be merged but no released.

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiroppy when is this planned to be released?

hiroppy and others added 2 commits May 14, 2020 09:22
Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
@hiroppy
Copy link
Member Author

hiroppy commented May 14, 2020

@EugeneHlushko We plan to release webpack-dev-server@4 next week but not established. However, we have only one remaining task so I think it can. Anyway, I'm going to submit many PRs for v4 so please review! (but don't merge them<3

@EugeneHlushko
Copy link
Member

@hiroppy did this get released yet? been a while

@hiroppy
Copy link
Member Author

hiroppy commented Aug 25, 2020

@EugeneHlushko not yet. see webpack/webpack-dev-server#2592

Copy link
Contributor

@jeffin143 jeffin143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be merged now

@hiroppy
Copy link
Member Author

hiroppy commented Dec 11, 2020

hm, I don't think so because the webpack-dev-server is beta currently.

@montogeek
Copy link
Member

Do we still need this?
Friendly ping @hiroppy

@snitin315
Copy link
Member

Closing in favor of :

@snitin315 snitin315 closed this Jul 23, 2021
@snitin315 snitin315 deleted the feature/modify-hot branch July 23, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants