Skip to content

mark line requiring uglifyjs-webpack-plugin as new #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2017

Conversation

avant1
Copy link
Contributor

@avant1 avant1 commented Sep 1, 2017

The uglifyjs-webpack-plugin plugin was installed on previous step, so
it should be marked as added line.

The `uglifyjs-webpack-plugin` plugin was installed on previous step, so
it should be marked as added line.
Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @skipjack I'll let you handle merge.

@avant1
Copy link
Contributor Author

avant1 commented Sep 2, 2017

Build failure seems to be unrelated:

> webpack.js.org@0.1.2 lint:links /home/travis/build/webpack/webpack.js.org
> hyperlink -r build/index.html --canonicalroot https://webpack.js.org/ | node ./src/scripts/check-links.js
Guessing --root from input files: file:///home/travis/build/webpack/webpack.js.org/build/
should respond with HTTP status 200
404 https://dl.dropboxusercontent.com/u/55764/npm-install-webpack-plugin.mp4 at build/plugins/npm-install-webpack-plugin/index.html:63:13 <a href="https://dl.dropboxusercontent.com/u/55764/npm-install-webpack-plugin.mp4">...</a>

@skipjack
Copy link
Collaborator

skipjack commented Sep 2, 2017

@avant1 yeah don't worry about that I'll take care of it and get this merged.

@skipjack
Copy link
Collaborator

skipjack commented Sep 2, 2017

Ok submitted webpack-contrib/install-webpack-plugin#118 to resolve that build error. I'm just going to merge this now though as the changes are pretty straightforward.

@skipjack skipjack merged commit 8b060b9 into webpack:master Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants