-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Correcting output log #1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting output log #1356
Conversation
Output log has been updated to match what is been displayed in the console when followed the steps mentioned. Output I am seeing: ~/Projects/js/webpack-demo $ webpack Hash: ea8bef37f3fc13f92afb Version: webpack 3.0.0 Time: 658ms Asset Size Chunks Chunk Names bundle.js 544 kB 0 [emitted] [big] main [0] ./src/index.js 219 bytes {0} [built] [2] (webpack)/buildin/global.js 509 bytes {0} [built] [3] (webpack)/buildin/module.js 517 bytes {0} [built] + 1 hidden module ~/Projects/js/webpack-demo
@@ -246,7 +246,7 @@ Version: webpack 2.2.0 | |||
Time: 390ms | |||
Asset Size Chunks Chunk Names | |||
bundle.js 544 kB 0 [emitted] [big] main | |||
[0] ./~/lodash/lodash.js 540 kB {0} [built] | |||
[0] ./src/index.js 219 bytes {0} [built] | |||
[1] (webpack)/buildin/global.js 509 bytes {0} [built] | |||
[2] (webpack)/buildin/module.js 517 bytes {0} [built] | |||
[3] ./src/index.js 278 bytes {0} [built] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./src/index.js
is already mentioned at the bottom of these three examples so either that should be replaced with the + 1 hidden module
or we should re-evaluate these changes. I see you're on version 3 which is probably why the output is slightly different. I think maybe we should just add a warning at the top of this guide or in /guides/index.md
to indicate that output might vary between versions of webpack -- trying to always keep these up to date will not be easy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am using webpack 3.0.0. I assumed that the output log will always start with the entry file. It is a logical assumption; isn't it? If that is not the case or it can't be guaranteed, a generic guide line as you have mentioned will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, and I think that's ok -- but we'd need to update the whole diff in this case not just the first module (see my comment above).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the index of files in output; it is 0, 2, 3! I believe we should go with the generic guiding statement that would cover any such discrepancy.
Hash: ea8bef37f3fc13f92afb
Version: webpack 3.0.0
Time: 658ms
Asset Size Chunks Chunk Names
bundle.js 544 kB 0 [emitted] [big] main
[0] ./src/index.js 219 bytes {0} [built]
[2] (webpack)/buildin/global.js 509 bytes {0} [built]
[3] (webpack)/buildin/module.js 517 bytes {0} [built]
+ 1 hidden module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah maybe [1]
is the hidden module.
I believe we should go with the generic guiding statement that would cover any such discrepancy.
Sure would you like to add this statement or should I close this PR and open a separate one to update /guides/index
(and maybe /guides/getting-started
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go ahead.
Thank you
Output log has been updated to match what is been displayed in the console when followed the steps mentioned.
Results I am seeing when followed the article is: