Skip to content

Updates asset-management.md #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2017
Merged

Updates asset-management.md #1352

merged 2 commits into from
Jul 1, 2017

Conversation

TheDutchCoder
Copy link
Collaborator

Changed index.js to better line up with the next guide (Output Management).

Changed index.js to better line up with the next guide (Output Management).
@TheDutchCoder
Copy link
Collaborator Author

@skipjack not sure what this failed on :)

@skipjack
Copy link
Collaborator

skipjack commented Jul 1, 2017

Ah it failed on some other stuff that slipped in from other PRs. #1355 should address them, feel free to ignore.

@skipjack skipjack merged commit 6ea8987 into webpack:master Jul 1, 2017
@skipjack
Copy link
Collaborator

skipjack commented Jul 1, 2017

@TheDutchCoder can you see the commit guidelines here? Not a big deal, but we're trying to follow it so we can do some cool stuff later on like auto-generating changelogs and doc versioning. For examples you can look at the master branch or ping me if you have questions.

I still need to update the readme and writers-guide soon to reflect some of these things.

@TheDutchCoder
Copy link
Collaborator Author

@skipjack will do, I'm not familiar with them yet, so I'll try my best not to make this a mess ;)

@skipjack
Copy link
Collaborator

skipjack commented Jul 4, 2017

No worries I can always "Squash and Merge" things later on to keep the history clean but seeing as you're a frequent contributor, it's good for you to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants