Improve Plugin Documentation #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-plugin Resolves #815
…placement-plugin
bebraw
reviewed
May 29, 2017
| --- | ||
|
|
||
| ?> Review this content | ||
| The `LoaderOptionsPlugin` is unlike other plugins in that it is built for migration from webpack version 1 to version 2. In webpack v2, the schema for a `webpack.config.js` became stricter; no longer open for extension by other loaders and plugins. The intention is that you pass `options` directly to loaders and plugins (i.e. `options` are __not__ global or shared. |
|
|
||
| In the future this plugin may be removed. | ||
| W> This plugin may be removed in the future as it only exists for migration. |
There was a problem hiding this comment.
I would say will. Stronger incentive to move.
|
|
||
| ## Examples | ||
| Here's a simple example of how this plugin might be used: |
There was a problem hiding this comment.
I would drop "simple" as that's a filler word.
|
Merged, but again please ping me if anything here needs tweaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lead-in descriptions (#1161) and clean up content. Most of these changes were to the local plugin docs in this repo but I also opened a few prs on external repos where necessary like this one. Also adding documentation for #815.
Resolves #1161
Resolves #815