Skip to content

refactor: improve migration #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No need, just deprecation

Motivation / Use-Case

For better migration

Breaking Changes

No

Additional Info

No

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b453380) 90.17% compared to head (ef861d8) 90.06%.

Files Patch % Lines
lib/Server.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5040      +/-   ##
==========================================
- Coverage   90.17%   90.06%   -0.11%     
==========================================
  Files          15       15              
  Lines        1578     1581       +3     
  Branches      600      601       +1     
==========================================
+ Hits         1423     1424       +1     
- Misses        141      143       +2     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-akait alexander-akait merged commit 4e4c97f into master Feb 12, 2024
@alexander-akait alexander-akait deleted the refactor-proxy-migration branch February 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant